Support for repeatable directives #5
Conversation
|
This PR was made before the 2.13 PRs. I'm seeing in there the little arrows for example. Were you thinking this should go in supporting the non 2.13 version of this library or should we update this PR for 2.13? Or are the two not mutually exclusive? |
|
@jregistr I just missed some of the arrows when I merged master. I've pushed another commit replacing the rest (everywhere but in the CHANGELOG). |
|
By looking at the description of the original PR, Oleg wrote that we can merge this PR as soon as graphql/graphql-js#1541 is merged. |
|
The PR that was merged (graphql/graphql-js#1965) does not change the introspection. |
|
@yanns Should we remove the introspection changes (essentially the same operation as between those two PRs)? |
|
I would vote to keep the introspection even if that makes it different than the reference js implementation. Besides this, aside from rebasing for conflict resolution; what else is left to merge this PR? |
|
@jregistr can you please elaborate why you think we should merge this as it is? |
yanns
force-pushed
the
master
branch
5 times, most recently
from
bf1dfe9 to
1e0131b
Compare
This PR includes Oleg's work from sangria-graphql#412 merged into current master (which mostly involved replacing Unicode arrows). It closes this issue.