Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Iterable subtype bound to FromInput #160

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

ubaldop
Copy link
Contributor

@ubaldop ubaldop commented Apr 20, 2023

As a precondition for the enhancement suggested here, this adds slight improvements to the FromInput trait, namely:

  • introduction of an Iterable subtype bound
  • introduction of a new implicit, i.e.: iterableInput
  • loosen type in mapAndMarshal signature

@yanns
Copy link
Contributor

yanns commented Sep 9, 2024

I kind of missed that PR. I guess it's still actual?

@ubaldop
Copy link
Contributor Author

ubaldop commented Sep 9, 2024

if sangria-graphql/sangria#979 is still needed, yes :)

Copy link
Contributor

@yanns yanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try out then!

@yanns
Copy link
Contributor

yanns commented Sep 9, 2024

could you rebase it on the new main?

@ubaldop
Copy link
Contributor Author

ubaldop commented Sep 9, 2024

could you rebase it on the new main?

done

@yanns
Copy link
Contributor

yanns commented Sep 9, 2024

You need to add some exceptions in the mina binary checks:
https://github.com/sangria-graphql/sangria-marshalling-api/actions/runs/10774639006/job/29877690179?pr=160

Ex how to do it: https://github.com/sangria-graphql/sangria/blob/2f5aa8b457dd522530ab45689e1a83fdf176a152/build.sbt#L96

@ubaldop
Copy link
Contributor Author

ubaldop commented Sep 9, 2024

mimaBinaryIssueFilters added here: cde0579

@yanns yanns added this pull request to the merge queue Sep 10, 2024
Merged via the queue into sangria-graphql:main with commit 1f0cb13 Sep 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants