DRAFT / WIP: Limit number of errors returned (when variables are used)

[bc-dima-pasieka]

Follow up to #1017

The solution from the previous PR works only for cases where input is specified (hardcoded) as a part of the query but doesn't work/executed when variables are used. For example, the following query will still return an unlimited number of errors:

mutation createProduct($input: CreateProductInput!) {
  product {
    createProduct(input: $input) {
      ...
    }
  }
}

// variables
{
    "input":{
      "field_with_invalid_objects":[{},{},{},{},{}, ...]
    }
  }

@yanns I'd appreciate your guidance here on the best way to design it 🙂

[bc-dima-pasieka]

The idea was to define errorsLimit only once (e.g. on the queryValidator) and re-use in other places

[bc-dima-pasieka]

This code doesn't work correctly because I don't mutate errors buffer, but this is one of the options how it can be implemented

[bc-dima-pasieka]

it seems like there are other places where violations could be returned, but I'm not sure if they should be updated as well.

[bc-dima-pasieka]

Making it public so it can be re-used?

[yanns]

Thanks for PR.
I'm not very familiar with this code. What kind of help do you need?

[bc-dima-pasieka]

I'm not very familiar with this code

Got it! I was looking for some guidance on the best way/place to fix it. I guess I will need to dig deeper into the logic then 😃

[bc-dima-pasieka]

Closing in favor of #1034