Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22.3 Deprecations and changes #2362

Merged
merged 8 commits into from
Jan 12, 2022
Merged

22.3 Deprecations and changes #2362

merged 8 commits into from
Jan 12, 2022

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Jan 8, 2022

  1. debug=True and --debug do NOT automatically run auto_reload
  2. Default error render is with plain text (browsers still get HTML by default because auto looks at headers)
  3. config is required for ErrorHandler.finalize
  4. ErrorHandler.lookup requires two positional args
  5. Unused websocket protocol args removed

There is one more change that will need to happen in sanic-routing. That will take place in its own PR.

@ahopkins ahopkins requested a review from a team as a code owner January 8, 2022 20:56
@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

Merging #2362 (aa3c3ca) into main (8b0eaa0) will increase coverage by 0.178%.
The diff coverage is 37.500%.

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #2362       +/-   ##
=============================================
+ Coverage   86.070%   86.248%   +0.178%     
=============================================
  Files           60        60               
  Lines         5018      5003       -15     
  Branches       900       896        -4     
=============================================
- Hits          4319      4315        -4     
+ Misses         509       502        -7     
+ Partials       190       186        -4     
Impacted Files Coverage Δ
sanic/app.py 86.636% <0.000%> (-0.131%) ⬇️
sanic/handlers.py 95.384% <66.666%> (+4.670%) ⬆️
sanic/server/protocols/websocket_protocol.py 68.181% <100.000%> (+5.681%) ⬆️
sanic/server/protocols/http_protocol.py 83.720% <0.000%> (-3.489%) ⬇️
sanic/errorpages.py 97.938% <0.000%> (+1.030%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b0eaa0...aa3c3ca. Read the comment docs.

@ahopkins ahopkins merged commit 8dfa49b into main Jan 12, 2022
@ahopkins ahopkins deleted the 22.3-changes branch January 12, 2022 14:28
ChihweiLHBird pushed a commit to ChihweiLHBird/sanic that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant