Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecation warning in asyncio.wait #2383

Merged
merged 2 commits into from
Jan 19, 2022
Merged

fix: deprecation warning in asyncio.wait #2383

merged 2 commits into from
Jan 19, 2022

Conversation

SaidBySolo
Copy link
Member

close #2377

@SaidBySolo SaidBySolo requested a review from a team as a code owner January 18, 2022 12:38
@codecov
Copy link

codecov bot commented Jan 18, 2022 •
edited
Loading

Codecov Report

Merging #2383 (d13a11b) into main (b8d9914) will decrease coverage by 0.034%.
The diff coverage is 0.000%.

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #2383       +/-   ##
=============================================
- Coverage   87.097%   87.062%   -0.035%     
=============================================
  Files           60        60               
  Lines         4999      5001        +2     
  Branches       904       904               
=============================================
  Hits          4354      4354               
- Misses         473       475        +2     
  Partials       172       172
Impacted Files Coverage Δ
sanic/server/websockets/impl.py 29.186% <0.000%> (-0.141%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8d9914...d13a11b. Read the comment docs.

ahopkins
ahopkins previously approved these changes Jan 18, 2022
View reviewed changes
@SaidBySolo SaidBySolo requested a review from ahopkins January 19, 2022 04:12
@ahopkins ahopkins merged commit bb517dd into sanic-org:main Jan 19, 2022
@SaidBySolo SaidBySolo deleted the fix/GH-2377 branch January 19, 2022 06:22
@SaidBySolo SaidBySolo restored the fix/GH-2377 branch March 25, 2022 05:10
@ahopkins ahopkins mentioned this pull request Mar 30, 2022
Merged
@SaidBySolo SaidBySolo deleted the fix/GH-2377 branch March 31, 2022 00:44
ChihweiLHBird pushed a commit to ChihweiLHBird/sanic that referenced this pull request Jun 1, 2022
@SaidBySolo @ChihweiLHBird
fix: deprecation warning in asyncio.wait (sanic-org#2383)
ba38b70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahopkins ahopkins ahopkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update websockets implementation for 3.11
2 participants
@SaidBySolo @ahopkins