-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditionally inject CLI arguments into factory #2402
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2402 +/- ##
=============================================
- Coverage 87.243% 87.183% -0.060%
=============================================
Files 60 60
Lines 5017 5017
Branches 904 904
=============================================
- Hits 4377 4374 -3
- Misses 468 470 +2
- Partials 172 173 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Wanna add a test?
I was waiting until #2401 is merged so that the tests could reuse the same fake factory module. |
When starting with
--factory
, the CLI will attempt to inject the CLI argumentsNamespace
into the factory (if possible).Additional benefit is that we will allow arbitrary arguments in the CLI in factory mode.