Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning filter #2546

Merged
merged 4 commits into from
Sep 18, 2022
Merged

Add deprecation warning filter #2546

merged 4 commits into from
Sep 18, 2022

Conversation

ahopkins
Copy link
Member

closes #2538

app.config.DEPRECATION_FILTER = "ignore"

Allowed values

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 87.846% // Head: 87.834% // Decreases project coverage by -0.012% ⚠️

Coverage data is based on head (1d695ad) compared to base (4726cf1).
Patch coverage: 83.333% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2546       +/-   ##
=============================================
- Coverage   87.846%   87.834%   -0.013%     
=============================================
  Files           78        78               
  Lines         6451      6461       +10     
  Branches      1244      1246        +2     
=============================================
+ Hits          5667      5675        +8     
- Misses         559       560        +1     
- Partials       225       226        +1     
Impacted Files Coverage Δ
sanic/app.py 87.500% <ø> (-0.044%) ⬇️
sanic/config.py 97.452% <83.333%> (-1.169%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@sjsadowski sjsadowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ahopkins ahopkins merged commit 7f894c4 into main Sep 18, 2022
@ahopkins ahopkins deleted the issue2538 branch September 18, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sanic enables writing of DeprecationWarning to the log
2 participants