Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume body on DELETE by default #2711

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Consume body on DELETE by default #2711

merged 2 commits into from
Mar 15, 2023

Conversation

ahopkins
Copy link
Member

This will solve a lot of confusion as it pops up from time to time as a gotcha.

@ahopkins ahopkins requested a review from a team as a code owner March 15, 2023 07:55
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 100.000% and project coverage change: +0.106 🎉

Comparison is base (88c918e) 88.539% compared to head (4ac958a) 88.646%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2711       +/-   ##
=============================================
+ Coverage   88.539%   88.646%   +0.106%     
=============================================
  Files           87        87               
  Lines         6815      6817        +2     
  Branches      1171      1172        +1     
=============================================
+ Hits          6034      6043        +9     
+ Misses         537       533        -4     
+ Partials       244       241        -3     
Impacted Files Coverage Δ
sanic/mixins/routes.py 96.666% <ø> (ø)
sanic/worker/manager.py 94.047% <100.000%> (ø)
sanic/worker/process.py 89.285% <100.000%> (+0.194%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit 5a0ed75 into main Mar 15, 2023
@ahopkins ahopkins deleted the delete-consume-body branch March 15, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants