scheme arg to create the redirect should be 'https' #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this example is trying to redirect HTTP requests to the HTTPS server, the scheme should be 'https.' I haven't tried running the example by itself, but I'm surprised it works as it is. Perhaps it is because of https.config.SERVER_NAME, but I wouldn't expect that since it doesn't include the scheme (but does include the port).
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2712 +/- ##
========================================
Coverage ? 88.543%
========================================
Files ? 87
Lines ? 6817
Branches ? 1172
========================================
Hits ? 6036
Misses ? 537
Partials ? 244 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Tronic
approved these changes
Mar 16, 2023
ahopkins
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this example is trying to redirect HTTP requests to the HTTPS server, the scheme should be 'https.'