-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add name prefixing to BP groups #2727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2727 +/- ##
=============================================
+ Coverage 88.887% 88.962% +0.074%
=============================================
Files 92 92
Lines 6956 6967 +11
Branches 1185 1187 +2
=============================================
+ Hits 6183 6198 +15
+ Misses 529 527 -2
+ Partials 244 242 -2
☔ View full report in Codecov by Sentry. |
ChihweiLHBird
previously approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the removal of duplicate route naming, the following is no longer possible. This was a hidden use case that we did not have unit tests to cover, and so the change was not caught.
The solution is to add
name_prefix
to go along withversion_prefix
andurl_prefix
to the BlueprintGroup. This will allow proper constructing and nesting of blueprints and groups.TODO: