Drop old performance tests/benchmarks #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2846 +/- ##
=============================================
+ Coverage 88.390% 88.432% +0.041%
=============================================
Files 92 92
Lines 7158 7158
Branches 1229 1229
=============================================
+ Hits 6327 6330 +3
+ Misses 575 574 -1
+ Partials 256 254 -2 ☔ View full report in Codecov by Sentry. |
ahopkins
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests haven't really been touched or updated in 3+ years, some haven't been touched since 2017. I don't believe they serve any purpose and simply slow down the test portion of our pipeline.
I left the sanic performance test because it may be useful to gauge performance changes between releases.