Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Python 3.12 #2836 #2870

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Support for Python 3.12 #2836 #2870

merged 2 commits into from
Dec 21, 2023

Conversation

iAndriy
Copy link
Contributor

@iAndriy iAndriy commented Dec 6, 2023 •
edited by ahopkins
Loading

Closes #2836

@iAndriy iAndriy requested a review from a team as a code owner December 6, 2023 23:59
@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d0bbcf5) 88.268% compared to head (21f8ac2) 87.727%.

Additional details and impacted files 
@@              Coverage Diff              @@
##              main     #2870       +/-   ##
=============================================
- Coverage   88.268%   87.727%   -0.542%     
=============================================
  Files           93        93               
  Lines         7305      7431      +126     
  Branches      1254      1288       +34     
=============================================
+ Hits          6448      6519       +71     
- Misses         598       638       +40     
- Partials       259       274       +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iAndriy iAndriy force-pushed the py312 branch 3 times, most recently from 4a45906 to 94e8143 Compare December 7, 2023 00:39
@iAndriy iAndriy mentioned this pull request Dec 7, 2023
Closed
1 task
@iAndriy iAndriy closed this Dec 17, 2023
@iAndriy iAndriy reopened this Dec 17, 2023
@iAndriy iAndriy requested a review from a team as a code owner December 17, 2023 22:27
@iAndriy
Copy link
Contributor Author

iAndriy commented Dec 17, 2023

@ahopkins Good for review, could someone please take a look ?

@iAndriy iAndriy mentioned this pull request Dec 17, 2023
Merged
@ahopkins ahopkins merged commit 29d4289 into sanic-org:main Dec 21, 2023
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahopkins ahopkins ahopkins approved these changes

Assignees
No one assigned
Labels
on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Python 3.12
2 participants
@iAndriy @ahopkins