Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 23.12 Release #2885

Merged
merged 19 commits into from
Dec 31, 2023
Merged

Version 23.12 Release #2885

merged 19 commits into from
Dec 31, 2023

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Dec 26, 2023

  • Remove 23.6 NEW
  • Deprecations
  • Release notes
  • Old docs notice

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b651636) 88.039% compared to head (3d85a1c) 88.026%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2885       +/-   ##
=============================================
- Coverage   88.039%   88.026%   -0.014%     
=============================================
  Files           94        94               
  Lines         7433      7433               
  Branches      1283      1283               
=============================================
- Hits          6544      6543        -1     
- Misses         622       623        +1     
  Partials       267       267               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahopkins ahopkins marked this pull request as ready for review December 26, 2023 10:28
@ahopkins ahopkins requested review from a team as code owners December 26, 2023 10:28
@ahopkins ahopkins merged commit 82c5529 into main Dec 31, 2023
53 checks passed

[homepage]: http://contributor-covenant.org
[version]: http://contributor-covenant.org/version/1/4/
See https://sanic.dev/en/organization/code-of-conduct.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahopkins Would it make sense to bump up the code of conduct to latest one (v2.1), it will have more details on the Enforcement Guidelines + other details.
Additionally, would you object if I will add Sanic to the list of adopters ? (https://github.com/EthicalSource/contributor_covenant/blob/release/README.md#registering-your-community-as-an-adopter)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to read it to see what it is adding, but sounds good.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahopkins i can raise MR, this will give side by side + collaboration page.
would it be useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants