-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up of examples. #764
Conversation
…es remaining to strictly follow PEP 8 styling guidelines. Non-Core examples will be moved to Wiki.
Can an admin enable the Wiki please so I can move non-core examples? Takes 5 seconds to do. Thanks. |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add the existing examples to the wiki before going ahead and removing them.
Relates to #382 |
add this to new "Examples" wiki file since editing is restricted. https://github.com/stopspazzing/sanic/wiki/Examples Only question I have is on this example: |
@stopspazzing I'd say that's core. Let me contact @channelcat about seeing about wiki edit permissions |
@seemethere Reason I ask is because the client.py file requires an outside core import of 'requests' meaning that should be added to requirements.txt (or dev). |
@stopspazzing the wiki looks great |
Thanks. |
Wouldn't it be a good idea to move extensions list from docs to Wiki? Not core material... Any thoughts? @r0fls @seemethere |
non-core content moved to wiki
Woot, wiki is enabled and editable: Deleted extensions.md as content was moved to wiki: Let me know if anything needs to be fixed or changed before can be merged. |
@stopspazzing You might need to fix the merge conflict that has occurred and update the current extension wiki to include the new changes from the existing extension docs. Particularly #782 |
Done. Good to go. Oh, you can close issue #396 once merged. 👍 |
Removes non-core examples, optimizes, and formatted remaining to strictly follow PEP 8 styling guidelines. Non-Core examples will be moved to Wiki.