Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up of examples. #764

Merged
merged 6 commits into from
Jun 20, 2017
Merged

Clean up of examples. #764

merged 6 commits into from
Jun 20, 2017

Conversation

stopspazzing
Copy link
Contributor

Removes non-core examples, optimizes, and formatted remaining to strictly follow PEP 8 styling guidelines. Non-Core examples will be moved to Wiki.

…es remaining to strictly follow PEP 8 styling guidelines. Non-Core examples will be moved to Wiki.
@stopspazzing
Copy link
Contributor Author

Can an admin enable the Wiki please so I can move non-core examples? Takes 5 seconds to do. Thanks.

@seemethere
Copy link
Member

Done

Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add the existing examples to the wiki before going ahead and removing them.

@seemethere
Copy link
Member

Relates to #382

@stopspazzing
Copy link
Contributor Author

stopspazzing commented Jun 1, 2017

add this to new "Examples" wiki file since editing is restricted. https://github.com/stopspazzing/sanic/wiki/Examples

Only question I have is on this example:
Request Stream
examples/request_stream/client.py
examples/request_stream/server.py
Considered core or put in wiki?

@seemethere
Copy link
Member

@stopspazzing I'd say that's core.

Let me contact @channelcat about seeing about wiki edit permissions

@stopspazzing
Copy link
Contributor Author

stopspazzing commented Jun 1, 2017

@seemethere Reason I ask is because the client.py file requires an outside core import of 'requests' meaning that should be added to requirements.txt (or dev).

@r0fls
Copy link
Contributor

r0fls commented Jun 2, 2017

@stopspazzing the wiki looks great

@stopspazzing
Copy link
Contributor Author

stopspazzing commented Jun 3, 2017

Thanks.
I have added Projects to wiki @r0fls because of #396
https://github.com/stopspazzing/sanic/wiki/Projects

@stopspazzing
Copy link
Contributor Author

stopspazzing commented Jun 9, 2017

Wouldn't it be a good idea to move extensions list from docs to Wiki? Not core material...
https://github.com/channelcat/sanic/blob/master/docs/sanic/extensions.md

Any thoughts? @r0fls @seemethere

non-core content moved to wiki
@stopspazzing
Copy link
Contributor Author

stopspazzing commented Jun 19, 2017

Woot, wiki is enabled and editable:
https://github.com/channelcat/sanic/wiki

Deleted extensions.md as content was moved to wiki:
https://github.com/channelcat/sanic/wiki/Extensions

Let me know if anything needs to be fixed or changed before can be merged.

@seemethere
Copy link
Member

@stopspazzing You might need to fix the merge conflict that has occurred and update the current extension wiki to include the new changes from the existing extension docs.

Particularly #782

@stopspazzing
Copy link
Contributor Author

stopspazzing commented Jun 20, 2017

Done. Good to go. extensions.md should be deleted after this merge. Should probably add info relating to wiki in readme.

Oh, you can close issue #396 once merged. 👍

@seemethere seemethere added this to the 0.6.0 milestone Jun 20, 2017
@seemethere seemethere merged commit b5369e6 into sanic-org:master Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants