Make client API CDN aware #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
bjoerge
pushed a commit
that referenced
this pull request
Sep 1, 2017
* [client] Make client CDN API aware * [client] Add documentation for createOrReplace/createIfNotExists methods
rexxars
added a commit
that referenced
this pull request
Jan 26, 2022
* [client] Make client CDN API aware * [client] Add documentation for createOrReplace/createIfNotExists methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make the client aware of our new API CDN.
If no
useCdnoption is specified when constructing, a warning is presented to the user (once), prompting them to take a stand and set it to true or false.Even if a user has set
useCdnto true, the client will fall back to using the live API for:Also snuck in documentation for
createOrReplace()/createIfNotExists(), which was missing. Sorry about that.