[client] Make node-specific middleware be excluded from bundles #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
approved these changes
Sep 10, 2017
bjoerge
pushed a commit
that referenced
this pull request
Sep 10, 2017
thomax
pushed a commit
that referenced
this pull request
Sep 14, 2017
bjoerge
pushed a commit
that referenced
this pull request
Sep 14, 2017
Merged
bjoerge
pushed a commit
that referenced
this pull request
Sep 19, 2017
rexxars
added a commit
that referenced
this pull request
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
headersanddebugmiddleware were being included in browser bundles. Tried to find a clean solution, but using thebrowserfield is the most reliable method I came up with which works both with browserify and with webpack.