Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(portable-text-editor): upgrade slate + remove workarounds #5175

Merged
merged 4 commits into from
Nov 14, 2023
Merged

chore(portable-text-editor): upgrade slate + remove workarounds #5175

merged 4 commits into from
Nov 14, 2023

Conversation

skogsmaskin
Copy link
Member

@skogsmaskin skogsmaskin commented Nov 11, 2023 •
edited
Loading

Description

This will upgrade slate and slate-react to the latest. Latest version of slate-react includes a bug fix related to ReactEditor's .focus function.

This means we now can remove a couple of workarounds we had in our code to work around this.

What to review

That the inputs are getting focused properly.

  • The comment input
  • The PT-input when changing block styles

Notes for release

N/A - no user-facing issues (due to current workarounds)

@vercel Vercel
Copy link

vercel bot commented Nov 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Nov 14, 2023 11:43am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 11:43am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 11:43am

@skogsmaskin skogsmaskin changed the title Chore/upgrade slate chore(portable-text-editor): upgrade slate + remove workarounds Nov 11, 2023
@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@socket-security Socket Security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
slate 0.100.0 None +1 2.68 MB ianstormtaylor
@types/lodash 4.14.201 None +0 863 kB types
slate-react 0.101.0 None +6 6.44 MB ianstormtaylor
is-hotkey 0.2.0 None +0 20 kB ianstormtaylor

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2023 •
edited
Loading

Component Testing Report Updated Nov 14, 2023 11:46 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 30s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 5s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 16s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 59s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 7s 3 0 0

@skogsmaskin skogsmaskin marked this pull request as ready for review November 11, 2023 11:50
@skogsmaskin skogsmaskin mentioned this pull request Nov 13, 2023
Merged
@skogsmaskin
chore(portable-text-editor): upgrade slate and slate-react to latest
fb23e9b
@skogsmaskin
refactor(portable-text-editor): remove workaround
f3c39e8 
This was a workaround for missing functionality in slate-react which is now fixed upstream
ianstormtaylor/slate#5527
@skogsmaskin
fix(core/form/inputs): remove workaround
634e24f 
This is not needed anymore as it's fixed upstream.
hermanwikner
hermanwikner approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@hermanwikner hermanwikner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 👍

@skogsmaskin skogsmaskin added this pull request to the merge queue Nov 14, 2023
Merged via the queue into next with commit 8aed3b1 Nov 14, 2023
38 checks passed
@skogsmaskin skogsmaskin deleted the chore/upgrade-slate branch November 14, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hermanwikner hermanwikner hermanwikner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skogsmaskin @hermanwikner