Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update create integration copy, use correct chevron icons #7842

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

robinpyon
Copy link
Contributor

@robinpyon robinpyon commented Nov 19, 2024

Description

This tiny PR includes some copy + icon only changes to the Studio Create integration. Purely cosmetic!

What to review

All copy has been pre-vetted, but please shout if anything looks out of place to you.

Testing

N/A – copy and icon changes only

Notes for release

Not required

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 9:29am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 9:29am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 9:29am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 9:29am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 9:29am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Nov 19, 2024 9:29am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Component Testing Report Updated Nov 19, 2024 9:30 AM (UTC)

❌ Failed Tests (2) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ❌ Failed (Inspect) 1m 0s 9 7 2
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 19s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 46s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 42s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 18s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 28s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 37s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Tue, 19 Nov 2024 09:22:48 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 16.7 efps (60ms) 17.2 efps (58ms) -2ms (-3.3%)
article (body) 59.5 efps (17ms) 58.0 efps (17ms) +0ms (+2.7%)
article (string inside object) 18.7 efps (54ms) 17.9 efps (56ms) +3ms (+4.7%)
article (string inside array) 16.1 efps (62ms) 15.9 efps (63ms) +1ms (+1.6%)
recipe (name) 29.9 efps (34ms) 30.3 efps (33ms) -1ms (-1.5%)
recipe (description) 34.5 efps (29ms) 34.5 efps (29ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 14.7 efps (68ms) 14.9 efps (67ms) -1ms (-1.5%)
synthetic (string inside object) 14.3 efps (70ms) 14.7 efps (68ms) -2ms (-2.9%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 60ms 66ms 77ms 260ms 541ms 13.1s
article (body) 17ms 19ms 35ms 208ms 286ms 6.1s
article (string inside object) 54ms 58ms 69ms 233ms 455ms 9.1s
article (string inside array) 62ms 71ms 83ms 226ms 651ms 9.2s
recipe (name) 34ms 36ms 39ms 85ms 8ms 9.6s
recipe (description) 29ms 31ms 33ms 59ms 0ms 5.8s
recipe (instructions) 6ms 8ms 9ms 9ms 0ms 3.2s
synthetic (title) 68ms 71ms 77ms 148ms 1330ms 16.1s
synthetic (string inside object) 70ms 74ms 95ms 533ms 2159ms 11.1s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 58ms 63ms 71ms 307ms 471ms 12.9s
article (body) 17ms 20ms 30ms 295ms 317ms 5.9s
article (string inside object) 56ms 59ms 69ms 187ms 310ms 8.7s
article (string inside array) 63ms 68ms 73ms 235ms 827ms 9.1s
recipe (name) 33ms 35ms 57ms 99ms 30ms 9.4s
recipe (description) 29ms 30ms 33ms 60ms 0ms 6.3s
recipe (instructions) 6ms 8ms 9ms 10ms 0ms 3.2s
synthetic (title) 67ms 72ms 82ms 543ms 1586ms 17.5s
synthetic (string inside object) 68ms 71ms 82ms 545ms 1344ms 10.4s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@robinpyon robinpyon marked this pull request as ready for review November 19, 2024 09:24
@robinpyon robinpyon requested a review from a team as a code owner November 19, 2024 09:24
@robinpyon robinpyon requested review from ryanbonial and RitaDias and removed request for a team November 19, 2024 09:24
Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@robinpyon robinpyon added this pull request to the merge queue Nov 19, 2024
Merged via the queue into next with commit 1d5d171 Nov 19, 2024
58 of 60 checks passed
@robinpyon robinpyon deleted the fix/create-integration-copy-changes branch November 19, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants