This repository has been archived by the owner on Dec 10, 2022. It is now read-only.
Properly parse ID3v2.2 tags #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add some explicit type annotations
sanket143
reviewed
Aug 4, 2021
sanket143
reviewed
Aug 8, 2021
|
Hello @moffatman, thanks a lot for contributing to id3 package. would you be interested in being a collaborator? |
|
do you have any plan to update the package anytime soon? |
|
yeah, this weekend |
|
@StarBattle08 published |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add some explicit type annotations
This solves #1 (I tested the file here: #6 (comment))