Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start working on README #1

Merged
merged 4 commits into from
Jun 6, 2022
Merged

Start working on README #1

merged 4 commits into from
Jun 6, 2022

Conversation

santib
Copy link
Owner

@santib santib commented Jun 5, 2022

No description provided.

@santib santib force-pushed the readme branch 4 times, most recently from 3cc4310 to f109449 Compare June 5, 2022 20:22
@santib
Copy link
Owner Author

santib commented Jun 6, 2022

@martinjaimem WDYT about merging this one? The README is not completed but it also makes some fixes to the gemspec and to class names

Copy link
Collaborator

@martinjaimem martinjaimem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR adds value as it is so I would merge it 👍 .

The only thing I'm not quite convinced about is just the first sentence:

AR2DTO (ActiveRecord to DTO, pronounced R2-D2 or Artoo-Detoo) is a gem that lets

As maybe it says more of what I want to given that I am a new user and just want to know what it is about. Having said that, I'm okay with it as it is now 👍

@santib
Copy link
Owner Author

santib commented Jun 6, 2022

I think this PR adds value as it is so I would merge it 👍 .

The only thing I'm not quite convinced about is just the first sentence:

AR2DTO (ActiveRecord to DTO, pronounced R2-D2 or Artoo-Detoo) is a gem that lets

As maybe it says more of what I want to given that I am a new user and just want to know what it is about. Having said that, I'm okay with it as it is now 👍

ok, I wanted to help people read the acronym out loud easily, but I'm ok if you want to make any change to it. I'm going to merge it, but feel free to open a PR with your suggestion

@santib santib merged commit f9b9377 into main Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants