Fix class_name when in a namespace #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # frozen_string_literal: true | ||
|
|
||
| module Payments | ||
| class Transaction < ActiveRecord::Base |
There was a problem hiding this comment.
I remember at some point in a project I tried to name a class Transaction and I had some unexpected errors. I checked and I also find this on stack overflow:
https://stackoverflow.com/questions/27388510/can-i-have-a-model-called-transaction-in-rails
Although one person says that it could have been due to the table name and here you specified another table name.
Just to mention that maybe another class name might be better to avoid having weird issues? 😅
sebaherrera07
approved these changes
Jun 28, 2022
santib
force-pushed
the
fix-class-name-with-namespace
branch
from
19bebc7 to
3b7643f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.