Feature/create alert form criteria #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nit Tests and minor changes to align with changes in API spec
packages/manager/src/features/CloudPulse/Alerts/CreateAlert/CreateAlertDefinition.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/CreateAlert/CreateAlertDefinition.tsx
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/CreateAlert/Criteria/Metric.test.tsx
Outdated
Show resolved
Hide resolved
| ).toBeInTheDocument(); | ||
|
|
||
| await user.click( | ||
| container.getByRole('option', { name: mockData[0].label }) |
There was a problem hiding this comment.
is await needed for this , since it is using mockdata, earlier it came as comment from CM team, hence asking
There was a problem hiding this comment.
The await here is because of the user.click, for userEvent we are using await.
https://github.com/linode/manager/blob/1072d546d7165e4a59aaaa753311a24a100cac50/packages/manager/src/features/CloudPulse/Alerts/CreateAlert/GeneralInformation/EngineOption.test.tsx#L31-L32
…de#11354) * upcoming: [DI-20929] - Added labels parameter to global filter change handlers * upcoming: [DI-20929] - Added cloudpulse applied filter * upcoming: [DI-20929] - Added test cases * upcoming: [DI-20929] - updated failing test cases * upcoming: [DI-22221] - Fixed console error * upcoming: [DI-20929] - Added changeset * upcoming: [DI-20929] - Updated changeset * upcoming: [DI-20929] - Updated import libraries * upcomign: [DI-20929] - Updated types * upcomign: [DI-20929] - Updated types * upcoming: [DI-20929] - Updated styles for dark theme * upcoming: [DI-20929] - Updated styling * upcoming: [DI-20929 ] - Eslint issue fixed * upcoming: [DI-20929] - updated function order * upcoming: [DI-20929] - Improve code readability
…de#11321) * initial types * small fixes * support nodes * update validatoon schemas * add changesets * add comment * clean up types in manager * add changeset * clean up validation schemas * update and fix more nodebalancer schemas * make validation schema more strict * more improvements to schemas --------- Co-authored-by: Banks Nussman <banks@nussman.us>
* cypress test and small text changes * feat: dedicated LKE create cluster Cypress test for APL * fix: mocking apl feature flag * mock APL account beta * save progress * save prpgress on mocking all LKE creation * post rebase cleanup * Wrap up lke-create * cleanup * Added changeset: Mock LKE creation flow + APL coverage * feedback @bnussman-akamai @hkhalil-akamai * missing one mock * Added changeset: Nullable AccountBeta ended & description properties * damn you, APL * feedback @jdamore-linode * fix maybe flake * fix other flake --------- Co-authored-by: dennisvankekem <dvankeke@akamai.com>
…11379) * fix: [M3-8796] - Disallow word-break in billing contact info * Added changeset: Disallow word-break in billing contact info
…nit tests, added a type for the Form, renamed prop
| <Stack spacing={2} sx={(theme) => ({ marginTop: theme.spacing(3) })}> | ||
| {fields.map((field, index) => { | ||
| return ( | ||
| <Metric |
There was a problem hiding this comment.
shouldn't here a check should be there for checking if fields is not undefined or null?
…le and added relevant api endpoints (linode#11346) * upcoming: [DI-22217] - Added AlertListing component With Table headers, Table rows and added the GET api endpoint and mockServer for fetching alert definitions * upcoming : [DI-22217] - Added the TableRowError and TableRowLoading for the AlertListing Table and minor changes * upcoming: [DI-22217] - Added changesets * upcoming: [DI-22217] - Review changes: Improving AlertListing test cases, unabbreviated UT to Unit Tests in changeset * upcoming: [DI-22217] - Removed unused import * upcoming: [DI-22217] - Review changes: Removed redundant checks, removed waitFor in the unit tests and removed Severity column, removed the Placeholder Icon for Alerts Landing empty state * upcoming: [DI-22217] - Restructured the alert queries * upcoming: [DI-22217] - Review changes: Added a TableRowLabelMap for the TableHead Row, Replaced referencing colors directly and used theme styling for colors * upcoming: [DI-22217] - fixed eslint error * upcoming: [DI-22217] - Minor styling changes and fixed failing tests * upcoming: [DI-22217] - minor changes: changed the key when mapping over AlertListingTableLabelMap, used shorthand
* initial commit: wire new router * Migrate test to use new helper * volumes landing routing * doin the filtering * wire actions * cleanup * cleanup * moar cleanup * more work on params * usePaginationV2 * cleanup * oops fix types * fix e2e * useOrderV2 * and... dont forget the util 🤦 * revert unwarranted change * useOrderV2 test * console error * A bit more cleanup * usePaginationV2 test * usePaginationV2 test * route level error handling * xFilter util * xFilter util improvements * post rebase fix * testing xQuery builder * moar testing and cleanup * Added changeset: Migrate `/volumes` to Tanstack router * Save progress * fix one test * fix remaining test * feedback @jaalah-akamai * more work on preloading * save progress * Walking back and using a more progressive approach * cleanup * entity not found logic * post rebase fix * post rebase fix * update loading state * fix the smoke tests * Feedback @bnussman-akamai * JsDocs for Tanstack link components * Improve new useOrder hook * feedback @coliu-akamai @hkhalil-akamai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Highlight the Pull Request's context and intentions.
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅
Commit message and pull request title format standards
<commit type>: [JIRA-ticket-number] - <description>Commit Types:
feat: New feature for the user (not a part of the code, or ci, ...).fix: Bugfix for the user (not a fix to build something, ...).change: Modifying an existing visual UI instance. Such as a component or a feature.refactor: Restructuring existing code without changing its external behavior or visual UI. Typically to improve readability, maintainability, and performance.test: New tests or changes to existing tests. Does not change the production code.upcoming: A new feature that is in progress, not visible to users yet, and usually behind a feature flag.Example:
feat: [M3-1234] - Allow user to view their login history