upcoming: [DI-21340] - Alert detail notification changes and CSS updates #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhagra-akamai
suggested changes
Dec 10, 2024
| /* | ||
| * The chips that needs to be displayed | ||
| */ | ||
| chips: Array<string> | Array<string[]>; |
There was a problem hiding this comment.
can we give it a proper name like values / labels. Chips name is not looking good
| export const DisplayAlertChips = React.memo((props: AlertDimensionsProp) => { | ||
| const { | ||
| chips: values, | ||
| isJoin = false, |
There was a problem hiding this comment.
may be no need to put default false, as undefined can also interpret as false for conditions
| marginLeft={isJoin && index > 0 ? -1 : 0} | ||
| > | ||
| <StyledAlertChip | ||
| borderRadius={getBorderRadius(isJoin, index, value.length)} |
There was a problem hiding this comment.
Suggested change
| borderRadius={getBorderRadius(isJoin, index, value.length)} | |
| borderRadius={getBorderRadius(index, value.length)} |
can we remove isJoin as parameter as it is already a global variable and can be accessed directly
| * @param length The length of the iteration so far | ||
| * @returns The border radius to be applied on chips based on the parameters | ||
| */ | ||
| const getBorderRadius = (isJoin: boolean, index: number, length: number) => { |
There was a problem hiding this comment.
Suggested change
| const getBorderRadius = (isJoin: boolean, index: number, length: number) => { | |
| const getBorderRadius = (index: number, length: number) => { |
Comment on lines
23
to
27
| mdLabel?: number; | ||
| /* | ||
| * Controls the size of the chip value from medium to larger screens | ||
| */ | ||
| mdValue?: number; |
There was a problem hiding this comment.
Suggested change
| mdLabel?: number; | |
| /* | |
| * Controls the size of the chip value from medium to larger screens | |
| */ | |
| mdValue?: number; | |
| labelWidth?: number; | |
| /* | |
| * Controls the size of the chip value from medium to larger screens | |
| */ | |
| valueWidth?: number; |
can we rename it to more understandable name
| <Grid alignItems="center" container item md={8} xs={12}> | ||
| <StyledAlertChip | ||
| borderRadius={theme.spacing(0.3)} | ||
| label={'All'} |
There was a problem hiding this comment.
Suggested change
| label={'All'} | |
| label= "All" |
| </Typography> | ||
| <StyledAlertChip | ||
| borderRadius={theme.spacing(0.3)} | ||
| label={` ${triggerOccurrences}`} |
There was a problem hiding this comment.
is space before triggerOccurences intentional?
| <DisplayAlertChips // label chip for evaluation period | ||
| chips={[convertSecondsToMinutes(evaluationPeriod)]} | ||
| isJoin | ||
| label={'Evaluation Periods'} |
There was a problem hiding this comment.
Suggested change
| label={'Evaluation Periods'} | |
| label="Evaluation Periods" |
no need to put string values as object notation. Same for every other places
nikhagra-akamai
approved these changes
Dec 10, 2024
santoshp210-akamai
merged commit 2fe2a0b
into
santoshp210-akamai:alerts-listing-show-details-integration-branch
18 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.