Plotly 3.8 compatibility #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a small fix needed for cufflinks to work with plotly.py version 3.8.0. Previously, cufflinks accessed
make_subplotsasplotly.plotly.plotly.tools.make_subplots. This wasn't intended as a public access point formake_subplots, and it was removed in plotly.py version 3.8.0. This PR updates cufflinks to access it atplotly.tools.make_subplots.This change is backward compatibly, so the minimum version constraint for plotly.py was not changed. I did add an upper version constraint of
<4.0.0a0so that cufflinks won't automatically install plotly.py version 4 when it is released (in a couple of months). v4 is making some changes to the internal representation of subplots (see plotly/plotly.py#1528), so cufflinks should be tested to see if any changes are necessary before the<4.0.0a0constraint is removed.