Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom input value in the most basic usage #2

Closed
yairEO opened this issue Feb 21, 2019 · 15 comments
Closed

Allow custom input value in the most basic usage #2

yairEO opened this issue Feb 21, 2019 · 15 comments

Comments

@yairEO
Copy link

yairEO commented Feb 21, 2019

First of all, awesome job. I am impressed.

See this demo:
https://sanusart.github.io/react-dropdown-select/examples

I would like to allow my users to fill any data they desire manually, while also allow the ability to select a pre-existing option from the dropdown.

The problem is, if a test is typed in the field, it disappears on the input's blur event...

Is there a solution to this?

Thanks!

@sanusart
Copy link
Owner

sanusart commented Feb 24, 2019

Thanks @yairEO
I guess prop can be added to control input clear. I guess clearOnBlur and clearOnSelect or something.

I would like to allow my users to fill any data they desire manually

Can you explain more on this, I don't really fully get it.

Maybe you mean to create new entries from users input into search?

@yairEO
Copy link
Author

yairEO commented Feb 24, 2019

I want the input to be able to accept any text typed into it, doesn't matter if the value is included in the dropdown list or not, it's not always desirable to limit the text to finite range or options.

Hopefully I've managed to explain this better

@sanusart
Copy link
Owner

Checkout the "Create new Entries" example on https://sanusart.github.io/react-dropdown-select/examples

Is that what you need?

@yairEO
Copy link
Author

yairEO commented Feb 24, 2019

I've checked out all the demos thoroughly, and that's not what i want.. I do not want tags.
I want an input element with one single value which is not a tag..

I am the author of Tagify and I do not need a tags script, but a script which specializes in dropdowns. I need a component which acts as a <select> element but can be styled as I wish

I think I understand what's going on here... I was completely miss-lead by the name of this script.. I thought it's a dropdown component when in facts in a tags component.. It's just not what the name stands for, this is not a customizable select element, since none of the example mimic the <select> element behavior.

@sanusart
Copy link
Owner

How is that not select exactly.
https://codesandbox.io/s/3kx74jlp0m

@yairEO
Copy link
Author

yairEO commented Feb 24, 2019

well, it is close..but I see some bugs:

Clicking the component doesn't show the dropdown. you must click exactly on the input and not on the actual container surrounding it, which is a major UX bug..

I'm clicking on some items and seeing a weird rendering:

image


Anyway, I would like to have the ability to enter any text I desire.

Thanks

@yairEO
Copy link
Author

yairEO commented Feb 24, 2019

I made a GIF of the weird stuff I saw:

https://gifyu.com/image/3LL2

@sanusart
Copy link
Owner

sanusart commented Feb 24, 2019 via email

@sanusart
Copy link
Owner

And yes. Click on the element should open the drop-down. Thanks for the input and clarifications.

@yairEO
Copy link
Author

yairEO commented Feb 24, 2019

Yes, I've checked many and we are currently using this one, which I strongly recommended against because it is exploding from bugs.

1000+ open issues...

We have been using it for some months as part of my client's project and we are looking for a better replacement since it also has open issues with major bugs and the maintainer does not respond as fast and politely as you are :)

@sanusart
Copy link
Owner

sanusart commented Feb 24, 2019 via email

@sanusart
Copy link
Owner

I think I've fixed all mentioned weirdness.
You can check them in if you want https://codesandbox.io/s/3kx74jlp0m if you have more suggestions feel free to list them, preferably in a separate issue.

@yairEO
Copy link
Author

yairEO commented Feb 25, 2019

So what about the props you've mentioned earlier in the comments?

clearOnBlur and clearOnSelect

@sanusart
Copy link
Owner

Forgot. Will keep this one open for now.

@sanusart
Copy link
Owner

Added in v2.1.1 via edc348e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants