Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required Flag missing #59

Closed
sagedemdreisbusch opened this issue Jan 7, 2020 · 3 comments
Closed

Required Flag missing #59

sagedemdreisbusch opened this issue Jan 7, 2020 · 3 comments

Comments

@sagedemdreisbusch
Copy link

Hi Sasha,
we have an issue with test automation when the dropdown is a required field. Is it possible to add the required flag to the html of the component?

Thanks a lot and best wishes
Max
@sanusart
Copy link
Owner

sanusart commented Jan 7, 2020 •
edited
Loading

Hey, does passing it to additionalProps as object helps?
E.g. additionalProps={{ required: true }}

EDIT: no not working

sanusart added a commit that referenced this issue Jan 8, 2020
@sanusart
FIX (usage in form): add requered prop and pattern, closes #59
35ccb20
@sanusart
Copy link
Owner

sanusart commented Jan 8, 2020

@sagedemdreisbusch
Checkout this build from pull request 60.

https://deploy-preview-60--react-dropdown-select.netlify.com/examples#Form-with-validation-(using-react-live) Is that solves the issue?

@sagedemdreisbusch
Copy link
Author

Hi Sasha, thank you very much for the really fast solution.
Seems to be the right one.

Best wishes Max

sanusart added a commit that referenced this issue Jan 11, 2020
@sanusart
FIX (usage in form): add required prop and pattern, closes #59 (#60)
709b33c 
* FIX (usage in form): add requered prop and pattern, closes #59

* CHORE (dependencies): update dependencies

* FIX (validation): proper validation hidden fields values

* CLEANUP (remove unused): remove unused dirs from source

* v3.9.0
See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
sanusart added a commit that referenced this issue Feb 13, 2020
@sanusart
FEATURE (events) [#70]: Remove selected option on key press of backsp…
30a2aee 
…ace button, closes #70 (#71)

* FIX (usage in form): add requered prop and pattern, closes #59

* CHORE (dependencies): update dependencies

* FIX (validation): proper validation hidden fields values

* CLEANUP (remove unused): remove unused dirs from source

* v3.9.0
See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
sanusart added a commit that referenced this issue Feb 13, 2020
@sanusart
Merge remote-tracking branch 'origin/next'
0190631 
* origin/next:
  v3.9.0 See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
  CLEANUP (remove unused): remove unused dirs from source
  FIX (validation): proper validation hidden fields values
  CHORE (dependencies): update dependencies
  FIX (usage in form): add requered prop and pattern, closes #59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sanusart @sagedemdreisbusch