FIX (types): fix item type for IItemRenderer #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix IItemRenderer interface to make item type generic and update addItem interface to include item as a parameter
|
@lopesc Please take a look. Thanks! |
|
Thanks @lopesc looks good. |
|
Published v3.6.6 |
|
Thanks @sanusart That was super quick. I was actually tidying up some more types as I go, so I'll create another PR when I am done. I like the idea of making these interfaces generic so that the consumer can specify what is the type of the objects in the list. Otherwise TS does not know how to handle the different function parameter, component props (options, values), etc. |
|
Great, thanks @lopesc, I never get to properly type stuff so this would be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix IItemRenderer interface to make item type generic and update addItem interface to include item as a parameter.
Fixes TS error where
addItem(item)expects 0 arguments. This is not correct asaddItemexpects the item as a parameter.