Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX (types): make options and values type generic #48

Merged
merged 2 commits into from
Nov 13, 2019
Merged

FIX (types): make options and values type generic #48

merged 2 commits into from
Nov 13, 2019

Conversation

lopesc
Copy link
Contributor

@lopesc lopesc commented Nov 12, 2019 •
edited
Loading

Make type of options and values generic with default type of object maintain backwards-compatibility

@lopesc
Copy link
Contributor Author

lopesc commented Nov 12, 2019

@sanusart PTAL. thanks

@lopesc lopesc closed this Nov 12, 2019
@lopesc lopesc reopened this Nov 12, 2019
@lopesc
Copy link
Contributor Author

lopesc commented Nov 12, 2019

Sets default type to object to maintain backwards-compatibility

@sanusart sanusart merged commit 00b8ddd into sanusart:master Nov 13, 2019
@sanusart
Copy link
Owner

Amazing, thanks @lopesc
Released v3.6.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lopesc @sanusart