Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_general_preconfigure: Fix check mode #935

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

berndfinger
Copy link
Member

Fixes issue #934.

Note: I also moved the when: lines to the end of the task Configure an English locale to match our current standard. For Get the current default locale, I moved changed_when to the end because that appears to be our default as well.

Fixes issue sap-linuxlab#934.

Signed-off-by: Bernd Finger <bfinger@redhat.com>
New codespell error after codespell update from 2.3.0 to 2.4.0

Signed-off-by: Bernd Finger <bfinger@redhat.com>
Copy link
Contributor

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@berndfinger berndfinger merged commit 0c6cd33 into sap-linuxlab:dev Jan 23, 2025
4 of 5 checks passed
@berndfinger berndfinger deleted the issue-934 branch January 23, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants