Skip to content

Commit

Permalink
do not inherit tier label across different rules
Browse files Browse the repository at this point in the history
  • Loading branch information
majewsky committed Oct 12, 2023
1 parent b8553b7 commit 07e8216
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion controllers/labels.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,9 @@ func (r *PrometheusRuleReconciler) labelOptsWithCCloudDefaults(
opts.DefaultService = newIfCurrentEmpty(opts.DefaultService, s)

t, s := mostCommonTierAndServiceCombo(rg)
opts.DefaultTier = newIfCurrentEmpty(opts.DefaultTier, t)
// opts.DefaultTier = newIfCurrentEmpty(opts.DefaultTier, t) // the `tier` label is sort of deprecated, do not inherit it between rules
opts.DefaultService = newIfCurrentEmpty(opts.DefaultService, s)
_ = t

return opts, nil
}
Expand Down

0 comments on commit 07e8216

Please sign in to comment.