Skip to content

Commit

Permalink
Fix lints
Browse files Browse the repository at this point in the history
  • Loading branch information
Nuckal777 committed Sep 4, 2024
1 parent 686e52b commit cd32590
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions internal/ghworkflow/workflow_release.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"strings"

"github.com/sapcc/go-bits/must"

"github.com/sapcc/go-makefile-maker/internal/core"
)

Expand Down
2 changes: 1 addition & 1 deletion internal/makefile/render.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ func (m *makefile) help() *rule {
}

result.addRecipe(`@printf "\n"`)
cNameTitleCase := strings.Title(cName) //nolint:staticcheck // ignore SA1019 (strings.Title is still fine for ASCII-only input)
cNameTitleCase := strings.Title(cName)

Check failure on line 164 in internal/makefile/render.go

View workflow job for this annotation

GitHub Actions / Checks

SA1019: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (staticcheck)
result.addRecipe(`@printf "%s\n"`, brightStr(cNameTitleCase))
if cName == "general" {
// Add help for targets generated from other targets.
Expand Down

0 comments on commit cd32590

Please sign in to comment.