Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace github.com/docker/distribution with github.com/containers/image/v5 #482

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace github.com/docker/distribution with github.com/containers/image/v5 #482

wants to merge 2 commits into from

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 17, 2025 •
edited
Loading

No description provided.

@SuperSandro2000 SuperSandro2000 changed the title Replace github.com/docker/distribution with github.com/containers/ima… Replace github.com/docker/distribution with github.com/containers/image/v5 Jan 17, 2025
@SuperSandro2000 SuperSandro2000 force-pushed the bye-docker-distribution branch from 65a8e89 to 389a821 Compare January 17, 2025 18:25
SuperSandro2000
SuperSandro2000 commented Jan 17, 2025
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 force-pushed the bye-docker-distribution branch 9 times, most recently from 06db2c7 to d819de1 Compare January 21, 2025 13:43
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review January 21, 2025 17:13
majewsky
majewsky requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@majewsky majewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch:

internal/client/download_test.go Outdated Show resolved Hide resolved
internal/client/validate.go Outdated Show resolved Hide resolved
internal/client/validate.go Outdated Show resolved Hide resolved
internal/keppel/manifest.go Outdated Show resolved Hide resolved
internal/keppel/manifest.go Outdated Show resolved Hide resolved
internal/keppel/manifest.go Outdated Show resolved Hide resolved
internal/keppel/manifest.go Outdated Show resolved Hide resolved
internal/processor/manifests.go Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 force-pushed the bye-docker-distribution branch 5 times, most recently from 0f99c2b to 6f0a528 Compare January 22, 2025 14:48
majewsky
majewsky requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@majewsky majewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually got through everything this time. \o/

internal/client/validate.go Show resolved Hide resolved
internal/processor/manifests.go Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 force-pushed the bye-docker-distribution branch 2 times, most recently from ca469ca to ef467c8 Compare February 4, 2025 20:50
@majewsky
Copy link
Contributor

majewsky commented Feb 5, 2025

One problem remains: We have a dep somewhere that forces go 1.23.4 in go.mod. Do you see a way to get rid of this?

@SuperSandro2000
Copy link
Member Author

nope

@SuperSandro2000 SuperSandro2000 force-pushed the bye-docker-distribution branch from cdbca97 to ca97d03 Compare February 5, 2025 18:28
@majewsky majewsky mentioned this pull request Feb 7, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majewsky majewsky majewsky approved these changes

@VoigtS VoigtS Awaiting requested review from VoigtS VoigtS is a code owner

@Nuckal777 Nuckal777 Awaiting requested review from Nuckal777 Nuckal777 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuperSandro2000 @majewsky