Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use React.Children.toArray instead of manual conversion #3

Closed
saitonakamura opened this issue Apr 8, 2018 · 0 comments
Closed

Use React.Children.toArray instead of manual conversion #3

saitonakamura opened this issue Apr 8, 2018 · 0 comments

Comments

@saitonakamura
Copy link
Contributor

saitonakamura commented Apr 8, 2018 •
edited
Loading

react-group/index.js

Line 13 in b5e22ea

var children = props.children ? castArray(props.children) : [];

React has a built-in api to convert children to array even if it's a single element. It'll also do the falsy children filtering for you.

React.Children.toArray(props.children)

I've opened the PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saitonakamura