Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SP-3283 Improve the Python API client to include more cases #20

Merged

Conversation

sfendourakis
Copy link

Added cancer/tissue type and phenotype/disease examples. Also updated outdated links.

Copy link
Author

@sfendourakis sfendourakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ckopanos
I would appreciate suggestions on whether I need to add similar examples for vcf annotations. It's not clear to me the use case of such examples for vcf annotation.

Copy link
Contributor

@argyris-gardelakos argyris-gardelakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I run the two new examples on QA api with the below results:
chr22 ['CHEK2'] 0.002044324489320513 [248982]
chr15 T ['CLN6'] 1.2026458208057727e-05 [249450]

Copy link
Author

@sfendourakis sfendourakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a talk with @kchatzikok we decided to add vcf annotation examples.
@argyris-gardelakos please have a look at these too.

@sfendourakis sfendourakis force-pushed the SP-3283-improve-the-python-api-client-to-include-more-cases branch from 5409df1 to 9b882b1 Compare July 8, 2022 13:39
Copy link
Contributor

@argyris-gardelakos argyris-gardelakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.
Run both new examples without any issues:
example1
example2

@sfendourakis sfendourakis force-pushed the SP-3283-improve-the-python-api-client-to-include-more-cases branch from 908275b to be596e8 Compare September 2, 2022 09:44
@kchatzikok kchatzikok merged commit b5aacd6 into master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants