-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SP-3283 Improve the Python API client to include more cases #20
SP-3283 Improve the Python API client to include more cases #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ckopanos
I would appreciate suggestions on whether I need to add similar examples for vcf annotations. It's not clear to me the use case of such examples for vcf annotation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I run the two new examples on QA api with the below results:
chr22 ['CHEK2'] 0.002044324489320513 [248982]
chr15 T ['CLN6'] 1.2026458208057727e-05 [249450]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a talk with @kchatzikok we decided to add vcf annotation examples.
@argyris-gardelakos please have a look at these too.
5409df1
to
9b882b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…les. Also updated outdated links
908275b
to
be596e8
Compare
Added cancer/tissue type and phenotype/disease examples. Also updated outdated links.