Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyVCF3 requirement #23

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Fix PyVCF3 requirement #23

merged 1 commit into from
Oct 26, 2023

Conversation

gpanouts
Copy link
Contributor

If a user has a python virtual environment with PyVCF3==1.0.0 and then install the varsome api client, the PyVCF3 will not be updated since it meets the project’s requirement which is PyVCF3>=1.0.0. However this leads to an error:

$ varsome_api_annotate_vcf.py -g hg19 -k ${API_KEY} -i plain_variants.vcf -o out.vcf -p add-all-data=1
Traceback (most recent call last):
  File "/tmp_varsome_api/test_varsome_102423/bin/varsome_api_annotate_vcf.py", line 19, in <module>
    from varsome_api.vcf import VCFAnnotator
  File "/tmp_varsome_api/test_varsome_102423/lib/python3.7/site-packages/varsome_api/vcf.py", line 20, in <module>
    from vcf.parser import _Info, _encode_type
ImportError: cannot import name '_encode_type' from 'vcf.parser' (/tmp_varsome_api/test_varsome_102423/lib/python3.7/site-packages/vcf/parser.py)

We need to update the requirement to PyVCF3>=1.0.1 to resolve this.

@ckopanos ckopanos merged commit 96b54d2 into master Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants