Sp 4818 update varsome api client to use commitizen #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thasteris
requested review from
ckopanos,
Konstantinacc,
kchatzikok,
gpanouts,
bsantor,
DathanasiadisSaphetor,
n-zervos,
foteinipetsiniSA and
KonstantinosMavros
|
Great work @thasteris ! General question, wouldn't it be worth it to also add poetry to the |
|
Thanks @n-zervos , for your input, however in this phase in development we won't be implementing poetry, this will be moved to a later phase. @kchatzikok Do you agree? |
n-zervos
approved these changes
Mar 20, 2024
kchatzikok
approved these changes
Mar 26, 2024
|
@n-zervos @thasteris it's ok like that for now. We might consider adding poetry for dependency management in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.