Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write tests for Storage #130

Closed
groenroos opened this issue Mar 13, 2021 · 2 comments · Fixed by #320
Closed

Write tests for Storage #130

groenroos opened this issue Mar 13, 2021 · 2 comments · Fixed by #320
Assignees
@groenroos
Labels
maintenance Keep dependencies, code and conventions fresh
Milestone
M2 - Release 2.0

Comments

@groenroos
Copy link
Member

Continuing from #26, write tests for Storage
@groenroos groenroos added the maintenance Keep dependencies, code and conventions fresh label Mar 13, 2021
@groenroos groenroos added this to the M2 - Release 2.0 milestone Mar 13, 2021
@groenroos groenroos self-assigned this Mar 13, 2021
@groenroos
Copy link
Member Author

This module is a behemoth - I wonder if there is some sensible way to split it down further before writing tests?

@groenroos groenroos mentioned this issue Jun 6, 2021
Merged
@groenroos
Copy link
Member Author

Created #261 to split out Storage, which should be completed prior to this one.

groenroos added a commit that referenced this issue Oct 24, 2021
@groenroos
#130: Tests for new User methods from Storage
7d1adc4
groenroos added a commit that referenced this issue Oct 24, 2021
@groenroos
#130: Tests for new Request methods from Storage
7eb01fa
groenroos added a commit that referenced this issue Oct 24, 2021
@groenroos
#130: Write tests for Storage
9e04890
@groenroos groenroos mentioned this issue Oct 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@groenroos groenroos

Labels
maintenance Keep dependencies, code and conventions fresh
Milestone
M2 - Release 2.0
Development

Successfully merging a pull request may close this issue.

Tests for Storage, Request and User saplingjs/sapling
1 participant
@groenroos