Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get record count #171

Closed
groenroos opened this issue Apr 4, 2021 · 1 comment · Fixed by #415
Closed

Get record count #171

groenroos opened this issue Apr 4, 2021 · 1 comment · Fixed by #415
Assignees
Labels
feature Brand new features to Sapling

Comments

@groenroos
Copy link
Member

There's currently no good way to get the total count of records in a collection, besides sending a limitless GET query and counting the (possibly enormous) return in the client.

Implement some good way to get the record count for any given GET data query.

@groenroos groenroos added the feature Brand new features to Sapling label Apr 4, 2021
@groenroos groenroos added this to the M2 - Release 2.0 milestone Apr 4, 2021
@groenroos groenroos self-assigned this Apr 4, 2021
@groenroos
Copy link
Member Author

Open question; should this be a separate /api endpoint like getting the collection model, or should this be a containing JSON object in all the return values, which puts the actual return data inside data and sends some other meta, including total record count in the top-level object?

The first one is possibly easier to implement and has fewer implications throughout the project; the second one seems more convenient for the user and more of a standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Brand new features to Sapling
Development

Successfully merging a pull request may close this issue.

1 participant