Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to ESM #210

Closed
groenroos opened this issue May 17, 2021 · 1 comment · Fixed by #222
Closed

Convert to ESM #210

groenroos opened this issue May 17, 2021 · 1 comment · Fixed by #222
Assignees
@groenroos
Labels
refactoring Drastic code quality improvements
Milestone
M2 - Release 2.0

Comments

@groenroos
Copy link
Member

To unblock #206 in this and the equivalents in all the other repos, upgrade the whole thing to use ESM instead of CJS.
@groenroos groenroos added the refactoring Drastic code quality improvements label May 17, 2021
@groenroos groenroos added this to the M2 - Release 2.0 milestone May 17, 2021
@groenroos groenroos self-assigned this May 17, 2021
@groenroos
Copy link
Member Author

This seems to cause some problems related to the non-top-level requires, and ones that need dynamic dependency names. Need to see what to use for those.

This was referenced Jun 5, 2021
Merged
Closed
Closed
groenroos added a commit that referenced this issue Jul 31, 2021
@groenroos
#210: JIT importing dynamic dependencies
df0c81b
groenroos added a commit that referenced this issue Jul 31, 2021
@groenroos
#210: Tidy up tests
e41e343
groenroos added a commit that referenced this issue Jul 31, 2021
@groenroos
#210: Update new tests
ab61df2
groenroos added a commit that referenced this issue Aug 1, 2021
@groenroos
#210: Fix tests
e8eeda7
groenroos added a commit that referenced this issue Aug 1, 2021
@groenroos
#210: Fix async dependencies
b111ca3
groenroos added a commit that referenced this issue Aug 1, 2021
@groenroos
#210: Apply linter
a5db189
groenroos added a commit that referenced this issue Aug 1, 2021
@groenroos
#210: Fix loadRest tests
036b35f
groenroos added a commit that referenced this issue Aug 2, 2021
@groenroos
#210: Move from nyc to c8
e656b9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@groenroos groenroos

Labels
refactoring Drastic code quality improvements
Milestone
M2 - Release 2.0
Development

Successfully merging a pull request may close this issue.

Convert to ESM saplingjs/sapling
1 participant
@groenroos