Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Storage init variables #268

Closed
groenroos opened this issue Aug 4, 2021 · 0 comments · Fixed by #320
Closed

Unify Storage init variables #268

groenroos opened this issue Aug 4, 2021 · 0 comments · Fixed by #320
Assignees
@groenroos
Labels
refactoring Drastic code quality improvements
Milestone
M2 - Release 2.0

Comments

@groenroos
Copy link
Member

Storage constructor seems to be initialising some vars that don't seem necessary. Unify everything under this.app.
@groenroos groenroos added the refactoring Drastic code quality improvements label Aug 4, 2021
@groenroos groenroos added this to the M2 - Release 2.0 milestone Aug 4, 2021
@groenroos groenroos self-assigned this Aug 4, 2021
groenroos added a commit that referenced this issue Oct 24, 2021
@groenroos
#268: Standardise Storage constructor
a19b798
@groenroos groenroos mentioned this issue Oct 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@groenroos groenroos

Labels
refactoring Drastic code quality improvements
Milestone
M2 - Release 2.0
Development

Successfully merging a pull request may close this issue.

Tests for Storage, Request and User saplingjs/sapling
1 participant
@groenroos