Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use matchWildcard for Memory driver #417

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Conversation

groenroos
Copy link
Member

#416 introduced a matchWildcard method for generally supporting matching patterns with asterisk based wildcards.

This PR implements that method for the Memory DB driver.

@groenroos groenroos added the refactoring Drastic code quality improvements label Feb 21, 2022
@groenroos groenroos added this to the M2 - Release 2.0 milestone Feb 21, 2022
@groenroos groenroos self-assigned this Feb 21, 2022
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #417 (6ad95ce) into master (1cb6ee1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #417   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files          37       37           
  Lines        4581     4581           
=======================================
  Hits         4492     4492           
  Misses         89       89           
Impacted Files Coverage Δ
drivers/db/Memory.js 99.11% <100.00%> (ø)
lib/Utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb6ee1...6ad95ce. Read the comment docs.

@groenroos groenroos merged commit e166328 into master Feb 21, 2022
@groenroos groenroos deleted the fix/use-wildcard-matcher branch February 21, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Drastic code quality improvements
Development

Successfully merging this pull request may close these issues.

1 participant