Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate thumbnails for image uploads #434

Merged
merged 2 commits into from
Mar 20, 2022
Merged

Generate thumbnails for image uploads #434

merged 2 commits into from
Mar 20, 2022

Conversation

groenroos
Copy link
Member

Generate n number of thumbnails for each image upload, either from A) the file field definition in the model; B) user-supplied global definition in config; or C) fallback default definition in config.

Closes #89.

@groenroos groenroos added the feature Brand new features to Sapling label Mar 20, 2022
@groenroos groenroos added this to the M2 - Release 2.0 milestone Mar 20, 2022
@groenroos groenroos self-assigned this Mar 20, 2022
@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #434 (1195a8e) into master (4484aad) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   98.02%   98.06%   +0.03%     
==========================================
  Files          37       37              
  Lines        4607     4644      +37     
==========================================
+ Hits         4516     4554      +38     
+ Misses         91       90       -1     
Impacted Files Coverage Δ
core/loadConfig.js 100.00% <100.00%> (ø)
lib/Uploads.js 98.78% <100.00%> (+0.21%) ⬆️
lib/Templating.js 99.07% <0.00%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4484aad...1195a8e. Read the comment docs.

@groenroos groenroos merged commit a78f007 into master Mar 20, 2022
@groenroos groenroos deleted the feature/thumbnails branch March 20, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Brand new features to Sapling
Development

Successfully merging this pull request may close these issues.

Generate thumbnails of image uploads
1 participant