-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: Add mne logger #112
MRG: Add mne logger #112
Conversation
Also have to fix a couple of logs, as it seems I just did a |
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 99.04% 99.02% -0.02%
==========================================
Files 7 7
Lines 733 719 -14
==========================================
- Hits 726 712 -14
Misses 7 7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Please:
- add yourself here:
Line 43 in 4a91d31
} - and to the list of authors here: https://github.com/sappelhoff/pyprep/blob/master/docs/whats_new.rst (don't forget to also put a link at the bottom of the doc)
- finally, please prepare a short changelog entry (for syntax, see the previous entries)
We can ignore the codecov check.
Previously there was some RNG issue in the tests, that has now disappeared ... still a bit weird - but in any case unrelated to your changes.
Done |
Thanks @mscheltienne |
Closes #105.
I had this on my namespace for a while... (Oct 22. 2021) and I didn't take the time to finish it.
If I recall correctly, it's missing the ProgressBar class for the 10%... 20%... 30%... print output by the RANSAC (probably the most annoying one when I run this on 40 cores 😅).
I'll double-check the diff, make sure I didn't miss anything and add the ProgressBar for RANSAC.
Mathieu