Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert chn labels from list to array #117

Merged
merged 9 commits into from
Jul 29, 2022
Merged

Conversation

OleBialas
Copy link
Contributor

Added list-to-array conversion in ransac.find_bad_by_ransac test to test_find_bad_by_ransac.
closes #116

Copy link
Owner

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you follow the steps described here? --> https://numpy.org/doc/stable/reference/generated/numpy.asarray.html

else you'll have to install black, flake8, isort, etc. and manually run them on your changes to make sure that the codestyle complies with the rest of the library

pyprep/ransac.py Outdated Show resolved Hide resolved
Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
@OleBialas
Copy link
Contributor Author

I agree that using np.asarray is better

@sappelhoff
Copy link
Owner

@OleBialas
Copy link
Contributor Author

Done

@sappelhoff sappelhoff merged commit b4f628a into sappelhoff:master Jul 29, 2022
@sappelhoff
Copy link
Owner

Thanks @OleBialas

@OleBialas
Copy link
Contributor Author

My pleasure, thanks for inviting me to contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List of channel names causes TypeError in find_bad_by_ransac
2 participants