fix(optimizer): rebase: browser field bare import #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smeng9
changed the base branch from
fix/optimizer-browser-field-bare-import
to
main
|
Sorry I should have closed the PR and explained why it was in the draft state.
FYI this fail was a flaky one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sapphi-red
I have performed a rebase of your fix/optimizer-browser-field-bare-import branch on top of main branch
Comparing to the previous merge vitejs#8709 , the tests for macOS are passing now https://github.com/smeng9/vite/actions/runs/3004484619 .
Thanks for your time and can you help on getting this reviewed and close vitejs#7576 ?