Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump jest and use mjs #422

Merged
merged 5 commits into from
May 4, 2022
Merged

chore: bump jest and use mjs #422

merged 5 commits into from
May 4, 2022

Conversation

imranbarbhuiya
Copy link
Contributor

@imranbarbhuiya imranbarbhuiya commented Apr 27, 2022

TODO:

  • wait for the ts-jest stable release

I've checked the tests and couldn't find any use of jest-environment-jsdom or jest-jasmine2 but as they are present in resolution, I've added them. Should I remove them?

Edit: Blocked by kulshekhar/ts-jest#3453

@favna
Copy link
Member

favna commented Apr 27, 2022

Yes, remove jest-environment-jsdom and jest-jasmine2 from the dependencies. Skip-dependency is to do just that, force skip a dependency. But that is no longer necessary.

@favna
Copy link
Member

favna commented Apr 27, 2022

And you can also remove the explicit dependency on jest-circus and the testRunner: 'jest-circus/runner', line from the jest config.

jest.config.mjs Outdated Show resolved Hide resolved
@favna favna self-assigned this May 1, 2022
@imranbarbhuiya
Copy link
Contributor Author

done

@favna favna merged commit 210481a into sapphiredev:main May 4, 2022
@imranbarbhuiya imranbarbhuiya deleted the jest/28 branch May 5, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants