refactor: switch to split cjs and esm builds and fully build with tsup #697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I asked about this before in the server and I figured I'd just try it out, create a PR, and hear your thoughts on whether we merge this or not.
Zip of the new dist folder after running
prepack
:new-dist.zip
Are the types wrong report before:
Are the types wrong report after:
No problems found 🌟 ┌───────────────────┬───────────────────────┐ │ │ "@sapphire/framework" │ ├───────────────────┼───────────────────────┤ │ node10 │ 🟢 │ ├───────────────────┼───────────────────────┤ │ node16 (from CJS) │ 🟢 (CJS) │ ├───────────────────┼───────────────────────┤ │ node16 (from ESM) │ 🟢 (ESM) │ ├───────────────────┼───────────────────────┤ │ bundler │ 🟢 │ └───────────────────┴───────────────────────┘