fix: ensure browser compatibility

[imranbarbhuiya]

No description provided.

[codecov-commenter]

Codecov Report

Merging #150 (ad3ef28) into main (ebc46de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files          56       56           
  Lines        3230     3230           
  Branches      801      801           
=======================================
  Hits         3208     3208           
  Misses         13       13           
  Partials        9        9           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc46de...ad3ef28. Read the comment docs.

[favna]

I would like to see

• A browser test using vitest jsdom.
• A test for which new directory is created, a fresh node_modules is installed with only shapeshift and then an assert test is ran similar to the one deleted. Add a dependency which is a relative path to a .tgz file which is created with yarn pack in the pipeline. Then run yarn install in that directory and run the test file. Run this locally to make sure no node_modes from the root directory are loaded, I.e. by deleting it and then installing in the subdirectory. The test has to test both CJS and ESM so use .cjs and .mjs file extensions.

[imranbarbhuiya]

I would like to see

• A browser test using vitest happy-dom. This means excluding it from the normal test suite and creating a folder browser-tests then creating a separate vitest config and including only that folder.
• A test for which new directory is created, a fresh node_modules is installed with only shapeshift and then an assert test is ran similar to the one deleted. Add a dependency which is a relative path to a .tgz file which is created with yarn pack in the pipeline. Then run yarn install in that directory and run the test file. Run this locally to make sure no node_modes from the root directory are loaded, I.e. by deleting it and then installing in the subdirectory. The test has to test both CJS and ESM so use .cjs and .mjs file extensions.

for the 2nd point, I've removed bundling for cjs and mjs. Now it only bundles iife. So do u still need this test? it won't work without the other 2 deps

[imranbarbhuiya]

finally green ci 😄

[favna]

for the 2nd point, I've removed bundling for cjs and mjs. Now it only bundles iife. So do u still need this test? it won't work without the other 2 deps

No more need indeed because their compatibility now gets covered again by vitest.