Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed s.array type inference #153

Merged
merged 1 commit into from
Jul 10, 2022
Merged

Conversation

favna
Copy link
Member

@favna favna commented Jul 10, 2022

After this change the following 3 will all resolve their types properly:

16-59-52_10-07-2022_Code
17-00-08_10-07-2022_Code
17-00-37_10-07-2022_Code

@favna favna requested review from kyranet and vladfrangu as code owners July 10, 2022 15:01
@favna favna self-assigned this Jul 10, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #153 (d60737a) into main (ebc46de) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files          56       56           
  Lines        3230     3232    +2     
  Branches      801      801           
=======================================
+ Hits         3208     3210    +2     
  Misses         13       13           
  Partials        9        9           
Impacted Files Coverage Δ
src/lib/Shapes.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc46de...d60737a. Read the comment docs.

@favna favna merged commit a5948dc into main Jul 10, 2022
@favna favna deleted the fix/fixed-s-array-types-inference branch July 10, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants