Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add when constraint #223

Merged
merged 1 commit into from
Dec 11, 2022
Merged

feat: add when constraint #223

merged 1 commit into from
Dec 11, 2022

Conversation

imranbarbhuiya
Copy link
Contributor

@imranbarbhuiya imranbarbhuiya commented Nov 15, 2022

Not ready for review yet. I haven't even started. Just fixed the typings and added a test

I'll finish it after my exams. In the meantime, if anyone else is interested then u can create a pr and I'll close this one

The code is ready for review.

TODO:

  • Add more tests.

@imranbarbhuiya imranbarbhuiya marked this pull request as ready for review December 1, 2022 12:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Base: 99.35% // Head: 99.36% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (e2ebb91) compared to base (aae857c).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head e2ebb91 differs from pull request most recent head 74256fb. Consider uploading reports for the commit 74256fb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   99.35%   99.36%   +0.01%     
==========================================
  Files          57       58       +1     
  Lines        3400     3470      +70     
  Branches      811      828      +17     
==========================================
+ Hits         3378     3448      +70     
  Misses         13       13              
  Partials        9        9              
Impacted Files Coverage Δ
src/constraints/ObjectConstrains.ts 100.00% <100.00%> (ø)
src/constraints/util/isUnique.ts 100.00% <100.00%> (ø)
src/lib/errors/BaseConstraintError.ts 100.00% <100.00%> (ø)
src/validators/BaseValidator.ts 100.00% <100.00%> (ø)
src/validators/ObjectValidator.ts 97.89% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@favna favna self-assigned this Dec 3, 2022
@favna favna added the feature label Dec 3, 2022
README.md Outdated Show resolved Hide resolved
src/constraints/ObjectConstrains.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/constraints/ObjectConstrains.ts Show resolved Hide resolved
src/constraints/ObjectConstrains.ts Show resolved Hide resolved
vladfrangu
vladfrangu previously approved these changes Dec 10, 2022
@favna favna enabled auto-merge (squash) December 11, 2022 21:46
@favna favna merged commit 8eade90 into sapphiredev:main Dec 11, 2022
@imranbarbhuiya imranbarbhuiya deleted the feat/when branch December 12, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants